Re: [PATCH] Error message cleanup

Hi Richard, ----- Original Message ----- From: "Richard Quadling" Sent: Monday, September 25, 2006 > On 25/09/06, Matt W <php_lists@realplain.com> wrote: > > [...] > > > > I don't know if my regex search found all occurrences, but I fixed up the > > files I found. The only changes were removing a trailing period (or a space > > in a few places), and a couple typos I noticed in the ones I changed -- > > "interger", "can not" -> "cannot", I think that's > > about all. Also updated > > the necessary test files I found, to reflect the changes. I think (hope) > > everything's OK, but haven't tested it! > > > > [...] > > What's your regex? What files do you examine. > > I've found some error messages ending in ! and some ending with \n. Using my editor's (NoteTab) Search in Files tool, I searched all files, but then just *.c since only they had what I was looking for (AFAIK). The regex was php_error_docref\(.+\".+[. ]\" which does match incorrectly in some places, but I just skip ahead. :-) I looked at each one, so as to not do something wrong trying to do a blind "Replace All." (OT: I just now realized that I don't think I need to escape the regex's double quotes...? It works, but I must be too used to writing them only in quoted strings (PHP...). ;-)) I know some of the messages end with "!" (some "?" also), but I figure they should stay. The only place I found a \n (\ and n in the file) is in 6's main/streams/filter.c. That's kinda weird, though it would just appear as a space in the browser with HTML (e.g. should prob be changed too). There was another typo I wasn't sure about in ext/fbsql/php_fbsql.c: "FrontBase link is not connected, ty to reconnect" -- is it supposed to be "trying" or what? Matt