RE: [PHP-DEV] RC5 on Thursday
| From: | Dmitry Stogov | Date: | Thu, 05 Oct 2006 05:46:30 +0000 |
| Subject: | RE: [PHP-DEV] RC5 on Thursday | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-25943@lists.php.net to get a copy of this message | ||
I'll care about the problem.
Thank you for patch.
I'll review it.
Dmitry.
> -----Original Message-----
> From: Pierre [mailto:pierre.php@gmail.com]
> Sent: Thursday, October 05, 2006 3:04 AM
> To: Edin Kadribasic
> Cc: Ilia Alshanetsky; PHP Internals; dmitry@zend.com
> Subject: Re: [PHP-DEV] RC5 on Thursday
>
>
> Hello,
>
> On 10/4/06, Pierre <pierre.php@gmail.com> wrote:
> > Hello,
> >
> > On 10/4/06, Edin Kadribasic <edink@emini.dk> wrote:
> > > Hi all,
> > >
> > > We need to fix http://bugs.php.net/bug.php?id=38989
> > > before the
> > > release. Some change has broken path handling on windows recently.
> >
> > tsrm_virtual_cwd.c 1.74.2.9.2.3 is the last working version
> >
> (http://cvs.php.net/viewvc.cgi/TSRM/tsrm_virtual_cwd.c?revision=1.74.2
> > .9.2.3&view=markup&pathrev=PHP_5_2)
> >
> > There is a *lot* of changes, but as far as I can see,
> IS_ABSOLUTE_PATH
> > is broken. It is used in expand_filepath, for example:
>
> Please find a possible fix as attachment, I did not test it
> intensivelly but it seems to work. Edin, can you take a look at it?
>
> It is actually a wonder that this kind of paths worked before
> Dmitry's commit :)
>
> --Pierre
>