Re: [PATCH] Small typo in zend_u_strtol
| From: | Andrei Zmievski | Date: | Thu, 05 Oct 2006 16:28:01 +0000 |
| Subject: | Re: [PATCH] Small typo in zend_u_strtol | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-25952@lists.php.net to get a copy of this message | ||
Are you sure this is correct? I copied the source from BSD strtol implementation.
http://www.freebsd.org/cgi/cvsweb.cgi/src/lib/libc/stdlib/strtol.c?rev=1.19&content-type=text/x-cvsweb-markup
-Andrei
On Oct 5, 2006, at 1:50 AM, Matt W wrote:
Hi, Was this missed? I'm sure you want to fix it. :-) Maybe should've put "bug" instead of "typo" in the subject... Just also sending to you Andrei since it's Unicode related. Patch was an attachment: http://news.php.net/php.internals/25820 ----- Original Message ----- From: "Matt W" Sent: Monday, September 25, 2006Hi, Noticed this a couple months ago and never sent this simple thing. :-) ERANGE is being triggered too soon because of the wrong variable, which causes the following (in Unicode mode, of course) on 32-bit: (int) '2147483640' // int(2147483647) '2147483640' + 0 // float(2147483640) Instead of the expected int(2147483640) in both cases. Matt