Re: Smaller fix for the ext/filter boolean filter limitation (was Re: cvs: php-src /ext/filter long subject)
| From: | Pierre | Date: | Wed, 25 Oct 2006 12:22:06 +0000 |
| Subject: | Re: Smaller fix for the ext/filter boolean filter limitation (was Re: cvs: php-src /ext/filter long subject) | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-26251@lists.php.net to get a copy of this message | ||
Hello,
On 10/25/06, Skalpa Keo <keo.skalpa@gmail.com> wrote:
Hi, First my apologies for not being able to go a real reply to the real thread, but I just subscribed to the list a couple days ago (and the original thread subject was way too long anyway ;-)).The problem is solved and a new flag has been commited, FILTER_NULL_ON_FAILURE. --PierreBoolean values are the only case where it is not possible to distinguish FALSE from invalid as they can be FALSE, but it is really not an issue.If it wasn't an issue I wouldn't have fixed it. IMHO there's a more simple way to fix that without changing all the functions behavior. I think the distinction between NULL (non-existent data) and FALSE (invalid) should be kept and that having both cases return NULL, thus forcing users to use filter_has_var() to determine what this NULL means is a bit counter-intuitive.