Re: fgets()/fgetss() BC break in HEAD
| From: | Sara Golemon | Date: | Tue, 14 Nov 2006 20:59:09 +0000 |
| Subject: | Re: fgets()/fgetss() BC break in HEAD | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-26577@lists.php.net to get a copy of this message | ||
Antony Dovgal wrote:
On 11/14/2006 08:26 AM, Andi Gutmans wrote:As I told tony in IRC, I don't care if the behavior gets changed back to 5.2 style, although I don't think this is a BC we need to worry about keeping. I'll lay money that NOONE is relying on this, and I challenge any of you to prove me wrong on that count. If y'all do want maxcharsminusone behavior for the argument, fine, but rename the arg to something else. maxchars means "I want this many characters or less", not "I want one less than this many characters{or less}". -SaraSounds like something which indeed isn't worth breaking. Was this intentional?Sara says it was intentional, that's why I decided to write to the list. I don't think such intentional breaks should take place in any PHP version. It was quasi-intentional. The functions needed a lot of changes related to PHP6 Unicodiness and I implemented "maxchars" to mean "maxchars" rather than the appearantly expected "maxcharsbutnotreallycausewedonotwantthelastcharacter".