Re: [PATCH] For Bug #38770

On Wed, November 15, 2006 4:50 pm, David Soria Parra wrote: > It#s not the best way, the best way might be to cast the signed > integers > to unsigned in the pack command not in the unpack, but that might be a > BC. Assuming it works and does what it's supposed to for 'N' it seems like a fine patch to me... BUT: I would presume that somewhere "out there" in User-land PHP code, somebody is already working around this issue and their "fix" might be messed up by this changing. So, to some degree, this is a BC breaking bugfix. I dunno what policy is in place, but it seems to me that it would be best to only apply this patch in 6.x to avoid problems... This would be mitigated if, like, N is a not-often-used pack mode, and there is already another one that is the obvious work-around for it on 64-bit platforms, or something like that, so that it's super unlikely that there is any user-land code to work-around N in some way that this patch will break. -- Some people have a "gift" link here. Know what I want? I want you to buy a CD from some starving artist. http://cdbaby.com/browse/from/lynch Yeah, I get a buck. So?