Re: make test flag?

On Dec 1, 2006, at 3:21 PM, Marcus Boerger wrote:

Hello Brian, why should it do that? run-tests.php doesn't do anything with extensions. Meaning it only tests when you load your .so's by ini.

      $(PHP_EXECUTABLE) -d 'open_basedir=' -d 'safe_mode=0' -d 'output_buffering=0' -d 'memory_limit=-1' $(top_srcdir)/run-tests.php -d 'extension_dir=modules/' -d `( . $(PHP_MODULES) ; echo extension=$$dlname)` tests/; \

Given this only affects a make test being done in an extension that has been setup with a "phpize" command. Let me know if I've overlooked anything. I believe the above line that executes the "make test" causes two minor problems for ini files loading DSO's. First it sets the "extension_dir" to modules. Any attempt to load modules from installed ini files will fail because the path is now different. The second is that the last portion loads the extension by doing a "-d extension=<extname>" on the php commandline, which I causes my "already loaded error".

best regards marcus Saturday, December 2, 2006, 12:16:45 AM, you wrote:

On Dec 1, 2006, at 12:42 AM, Marcus Boerger wrote:

Hello Brian, therun-tests.php command will take care of any INI settings that are known to break tests.So if anyof your INI settings cause tests to failwe simply need to include them into the tests. Othewise it is important to test with your INI settings asyou want to know if your PHP installation works. Instead of knowing whether PHP in general could work.

Thanks Marcus,

The actual situation I'm thinking of is when you are running make test on an extension being built as a DSO that is already configured to load in an ini file. When make test is ran it will attempt to load the DSO twice, and gives: "PHP Warning: Module 'apc' already loaded in Unknown on line 0".

I thought the preference would be to ignore installed ini files, but if that's not the intention, then my proposed patch of course is bad.

-Brian Shire shire@facebook.com shire@php.net aim: int80h

Best regards, Marcus

-Brian Shire shire@facebook.com shire@php.net aim: int80h