Re: Unfortunate macro expansions leading to incorrect function names
| From: | Ilia Alshanetsky | Date: | Mon, 18 Dec 2006 19:40:34 +0000 |
| Subject: | Re: Unfortunate macro expansions leading to incorrect function names | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-27074@lists.php.net to get a copy of this message | ||
Looks fine to me.
+1
On 18-Dec-06, at 2:29 PM, Hannes Magnusson wrote:
Hi all Looking over skipped tests I noticed, one minor version to late, that inet_ntop() and inet_pton() are not available on fbsd. The reason is unfortunate macro expansion where inet_ntop & inet_pton get expanded to __inet_ntop & __inet_pton ergo => inet_ntop/pton() are named __inet_ntop/pton(). Attached is a patch adding ZEND_RAW_NAMED_FE/FENTRY macros fixing this issue. It also fixes the never ending libiconv()/iconv() saga (which can still be reproduced on fbsd with --with-iconv --with-xmlrpc). Objections? Comments? -Hannes <macro.expand.patch.txt> -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.phpIlia Alshanetsky