Re: Re: Unicode support for *printf()

Hi Andrei, Yeah, I see the patch you committed also included the changes that were made since my reply yesterday... I've attached a patch that removes a few lines that aren't present in the non-Unicode version. Matt ----- Original Message ----- From: "Andrei Zmievski" Sent: Tuesday, December 19, 2006 > Is this better? > > > -Andrei > > On Dec 18, 2006, at 6:22 PM, Matt Wilmas wrote: > > > Hi Andrei, > > > > Just a couple things I noticed in _appenddouble... In the first > > switch (), > > 'F' is being changed to 'f', and in the second switch, 'F' > > needs to be > > moved > > down with 'f'. Those changes were just made in v1.89 of the file. > > > > > > Matt

Index: ext/standard/formatted_print.c =================================================================== RCS file: /repository/php-src/ext/standard/formatted_print.c,v retrieving revision 1.92 diff -u -r1.92 formatted_print.c --- ext/standard/formatted_print.c 19 Dec 2006 18:41:40 -0000 1.92 +++ ext/standard/formatted_print.c 20 Dec 2006 02:20:06 -0000 @@ -431,7 +431,7 @@ TSRMLS_DC) { char num_buf[NUM_BUF_SIZE]; - char *s = NULL, *q, s_fmt; + char *s = NULL, s_fmt; UChar *uni_s; int s_len = 0, is_negative = 0; #ifdef HAVE_LOCALE_H @@ -506,7 +506,6 @@ s = num_buf; s_len++; } - s[s_len] = '\0'; break; case 0x67 /* 'g' */: @@ -530,10 +529,6 @@ } s_len = strlen(s); - - if (fmt == 0x47 /* 'G' */ && (q = strchr(s, 'e')) != NULL) { - *q = 'E'; - } break; }