Re: [PATCH] Small date() optimization
| From: | Ilia Alshanetsky | Date: | Fri, 22 Dec 2006 15:07:10 +0000 |
| Subject: | Re: [PATCH] Small date() optimization | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-27180@lists.php.net to get a copy of this message | ||
Matt,
The backslash removal is actually intentional. It is designed to handle instances such as "\d", in which case the format value is printed as a literal "d".
On 22-Dec-06, at 12:06 AM, Matt Wilmas wrote:
Hi, Just a simple patch for 5.2 to save smart_str_appends()'s strlen() calls in date_format(). It's already done in HEAD. Seems pretty safe for 5.2.1. :-) I also noticed that if the format string contains a backslash as the last character, it is lost (should be printed right?). So I changed that too and attached the patch for HEAD. 5.2's patch: http://realplain.com/php/date_optimization_5_2.diff Matt <date_backslash.diff.txt> --PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.phpIlia Alshanetsky