Doesn't seem like this ever got commited.
Can we include this in PHP 5.2.2? It doesn't break existing APIs so I
think it's a good idea.
I think adding bignum functions is OK (though it duplicates GMP to a measure) - while we are at it, why not add implementation for btwoc(number) also?
I think this patch is a bit narrow-purpose - why we have specific DSA verify and not for other algorithms? Why we have DSA verify but not DSA sign? Also, can't be dsa_verify plugged into openssl_verify()? I understand that it not receives hash and not data, but I see that practical use described here:
http://netevil.org/node.php?nid=949 generates hash from data, so no problem passing data either. So maybe we could instead of having separate verify functions have functions that compose keys from parameters for existing openssl_verify?
Also, some small things:
openssl_dh_generate_key on failure doesn't set return value to false. openssl_dh_generate_parameters on failure doesn't set return value.
openssl_bignum_from_zval alsway increases resource refcount, but in openssl_dh_generate_key when key is generated successfully refcount is not decreased, so it's not clear if participating bignums would ever be freed.
--
Stanislav Malyshev, Zend Products Engineer
stas@zend.com http://www.zend.com/