Re: Preliminary Apache 2 benchmarks

"Ilia A." <ilia@prohost.org> wrote: > On March 25, 2003 04:43 pm, lists@holsman.net wrote: > > resend due to 30k issue. > > > > > Attached is the patch (ap2.txt) that prevents AP2 handler from constantly > > > flushing the data as soon as it is passed. As you can see in the > > > benchmarks this more the doubles the performance when many writes occur. > > > I am hoping Ian can explain the need for this flush, since without it the > > > code would be clearly faster. > > > > in the general (like 99.9%) of the case you don't need to flush. > > I think disabling it will be a good thing. > > We do give the ability to the user to force a flush is they so desire, so I > think disabling the automatic flushing of data would be a good idea > especially since performance benefits are so significant. implicit_flush already works as a switch for that feature, so I think it's quite reasonable to remove flushing code from ub_write() function. Moriyoshi