Re: removed stuff & fatals error in HEAD
| From: | Johannes Schlüter | Date: | Fri, 23 Mar 2007 12:47:31 +0000 |
| Subject: | Re: removed stuff & fatals error in HEAD | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-28573@lists.php.net to get a copy of this message | ||
Hi,
I'd also like to completely remove get_magic_quotes_gpc() and similar
functions instead of having them resulting in a fatal error. The effect
would be the same - the script terminates - but function_exists() is
much nicer as check than version_compare().
Any objections?
johannes
On Fri, 2007-03-23 at 14:57 +0300, Antony Dovgal wrote:
> Hello all.
>
> I propose to change the error in HEAD that appears when enabling magic_quotes
> and safe_mode from E_ERROR to E_WARNING.
> It's not something that leaves the engine in unstable state, so I believe
> E_ERROR is misused in this case.
>
> It's also impossible to know even where exactly these INI options were declared
> if they appeared in php.ini:
>
> # php -i
> PHP Fatal error: Directive 'safe_mode' is no longer supported in PHP 6 and
> greater in Unknown on line 0
>
>
> I'll commit the patch in the evening if there are no (well-grounded) objections.
>
> --
> Wbr,
> Antony Dovgal
>