Re: Unexpected usage of 'duplicate' flag in sapi_add_header_ex()

On 04/04/2007 03:18 AM, js wrote:

Hi Antony. Thanks you for replying. If so, any reason to break the coding standard in this instance?

Standards are general rules, there might be some exceptions. (It doesn't mean I personally like this code or encourage to ignore the standards).

and what does, in this context, 'duplicate' means?

See main/main.c, line 1119 for example. It might be convenient to free duplicated buffer and ignore static one.

Then wouldn't it be nice call that flag static or no_duplicate or something? I thought 'duplicate' is misleading name.

Don't fix something that isn't broken. There are a lot of places requiring attention, this is not one of them. -- Wbr, Antony Dovgal