Re: cvs: php-src(PHP_5_2) / NEWS /ext/mysql php_mysql.c php_mysql.h
| From: | Antony Dovgal | Date: | Mon, 14 May 2007 17:38:51 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_2) / NEWS /ext/mysql php_mysql.c php_mysql.h | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-29416@lists.php.net to get a copy of this message | ||
I believe this should be reverted.
Adding new functions to ext/mysqli is _completely_ pointless, especially taking into account that this function is just an alias for "SET NAMES xx" and already implemented int MySQLi.
ext/mysql and ext/mysqli is like PHP4 and PHP5 - we can't keep adding new functions to ext/mysql, cause eventually it'll become ext/mysqli.
On 05/14/2007 09:30 PM, Scott MacVicar wrote:
Was discussed last summer and again in January this year, I forgot about it for 5.2.2 until recently. http://news.php.net/php.internals/27634 http://news.php.net/php.internals/27638 Spoke to ilia on IRC on Friday and his only comment was to use the new param parsing API. Scott Antony Dovgal wrote:-- Wbr, Antony DovgalOn 05/14/2007 09:10 PM, Scott MacVicar wrote:When and where was this discussed?scottmac Mon May 14 17:10:47 2007 UTCModified files: (Branch: PHP_5_2) /php-src NEWS /php-src/ext/mysql php_mysql.c php_mysql.hLog: Add mysql_set_charset() so that the connection encoding can be changed. This is similar to the SET NAMES statement but allows the mysql_real_escape_string to use the correct character set.