Re: fixing refcount overflow in PHP 4
| From: | Stanislav Malyshev | Date: | Mon, 21 May 2007 22:14:24 +0000 |
| Subject: | Re: fixing refcount overflow in PHP 4 | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-29648@lists.php.net to get a copy of this message | ||
thing is that I don't see macros ZVAL_SAFE_REF_ADD and ZVAL_SAFE_REF_SET used anywhere, so probably there's no need for them.My bad - they are used of course, I just looked into the wrong place. I would however rename ZVAL_SAFE_REF to something like ZVAL_SAFE_ADDREF. Also, comparing values to 0xffff might be not effective if they are ushort... -- Stanislav Malyshev, Zend Products Engineer stas@zend.com http://www.zend.com/