Re: PHP 5.2.3RC1 Released
| From: | Rasmus Lerdorf | Date: | Fri, 25 May 2007 07:51:19 +0000 |
| Subject: | Re: PHP 5.2.3RC1 Released | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-29739@lists.php.net to get a copy of this message | ||
Rasmus Lerdorf wrote:
> Uwe Schindler wrote:
>> I tried PHP 5.2.3RC1 today and the SunONE webserver using the NSAPI plugin
>> crashed in module startups with a segfault.
>>
>> This happens because rasmus changed tsrm_virtual_cwd.c to use
>> get_request_time instead of time() (see changelog of that file). During
>> module startup the extension browscap tries to open the browscap.ini file
>> and uses the TSRM functions to do that (because TSRM is used in NSAPI). At
>> module startup there is unfortunately no request running so the call to the
>> SAPI routine sapi_nsapi_get_request_time() core dumps because of a missing
>> server_context.
>>
>> I think that should be fixed because it affects all multithreaded webserver
>> SAPIs that supply a get_request_time-function.
>
> Could you try the attached patch please.
It should be a time(0) call there in the ternary, of course. Fixed
patch attached.
-Rasmus