Re: [PATCH] Converting accesses to refcount and is_ref to macros

From: Date: Sat, 14 Jul 2007 07:08:40 +0000
Subject: Re: [PATCH] Converting accesses to refcount and is_ref to macros
References: 1 2 3  Groups: php.internals 
Request: Send a blank email to internals+get-30911@lists.php.net to get a copy of this message
Was there some particular reason to remove those ()'s around the macros? (usually they're there for a reason :)
Also, extra ; is not needed and doesn't conform to the style of other PHP code. Macros usually don't need ; at the end. Also, these: +#define ZVAL_ADDREF(pz) ++(pz)->refcount; +#define OBJ_ADDREF(obj) ++(obj)->refcount; look quite confusing. And, PHP usually doesn't have _NP macros. If you need pointer and non-pointer macro, do non-pointer one and add _P's to it. -- Stanislav Malyshev, Zend Software Architect stas@zend.com http://www.zend.com/ (408)253-8829 MSN: stas@zend.com

« previous php.internals (#30911) next »