RE: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_2) / zend_language_parser.y

Yeah and we reviewed the patch and saw it was good. I think what's missing here is that to the best of my knowledge Ilia reached out off list to revert the patch but when that didn't happen after 2-3 days it was reverted. So the missing link here is the offlist email. It was definitely not a screw you... And the patch will go in right after 5.2.4. Andi > -----Original Message----- > From: Hannes Magnusson [mailto:hannes.magnusson@gmail.com] > Sent: Tuesday, August 14, 2007 12:31 AM > To: Stas Malyshev > Cc: internals@lists.php.net > Subject: Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_2) > / zend_language_parser.y > > On 8/14/07, Stanislav Malyshev <stas@zend.com> wrote: > > > A Major bugfix maybe ( yes, it was clearly a bug/misfeature) > > > > A bug is when code doesn't do what was intended. This is not the > case, > > this is the case of missing feature. While I think everybody agrees > this > > feature is good to us, it's not the time to add it. We lived for > years > > without it, we can live for a couple more monthes :) > > I totally agree that major changes like this should not go into a > minor bugfix releases. > The revert however came out of nowhere and felt like a big fat SCREW > YOU, ALL YOUR BASE ARE BELONG TO US. > > Andi wrote, 10 days ago, that he was OK with it if the patch was > "decent > (doesn't screw up common case and maintainability)" and was going to > look at the patch better "tomorrow"... > > -Hannes > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php