FW: [PHP-DEV] Patch for macros for tracking refcount and is_ref

When we all get a copy of the patch and get a chance to test it seriously we'll know more. I'm all in favor of having GC and very enthusiastic about this coming about but I doubt you can call it well enough tested. When we made memory manager changes in the past there were bugs which were only found after a public release. Even RCs and many people downloading it didn't help. In this case I still haven't had a chance to even play with the patch which I understand will be happening in a few days... If you have had a chance that's great but there are lots of others who want to too. The early patch I saw still needed work. Also, if GC slows certain situations down there may well be companies who would prefer to run without it. Facebook is probably a good example of a company where every % matters. The #if ZEND_GC is just an intermediate step so that we can commit the macro patch and get the GC patch for the list to review, play around with and test. It also gives us the flexibility to release a 5.2.x release if needed (urgent security fix). Once we get to the point where everyone feels comfortable with GC which shouldn't take too much time if it works as advertised we should discuss exactly how we want to handle it (enabled by default, configurable, how we handle compat with PECL). These things may be obvious to you but they aren't obvious to me right now. It may also very well be that after initial review we can make the default build GC, at least for the dev period so that we make sure it gets as much testing by ppl grabbing from CVS as possible. But let's first get the macro patch commited, get the GC patch against that and have a review period... Andi > -----Original Message----- > From: Cristian Rodriguez [mailto:judas.iscariote@gmail.com] > Sent: Friday, September 07, 2007 11:54 PM > To: internals@lists.php.net > Subject: Re: [PHP-DEV] Patch for macros for tracking refcount and > is_ref > > On 9/7/07, Andi Gutmans <andi@zend.com> wrote: > > >Let's not run before we walk. > > The GC already "walks." > > >There's still testing and review and some stabilizing period we > should be doing > > if it is disabled by default it is unlikely that people will test it > with real life code even more with in you place a #if ZEND_GC around > the functionality... > > -- > http://www.kissofjudas.net/ > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php