Re: rfc1867.c compatibility question

On 10.9.2007 6:53 Uhr, BuildSmart wrote: > > On Sep 10, 2007, at 24:41:47, Christian Stocker wrote: > > > >> On 10.9.2007 3:53 Uhr, BuildSmart wrote: >>> I was asked to look into the pdoru patch and extension by a client, this >>> is where I noticed that a similar patch is already applied to the >>> rfc1867.c file >>> >>> (http://cvs.php.net/viewvc.cgi/php-src/main/rfc1867.c?r1=1.173.2.1&r2=1.173.2.1.2.1&pathrev=PHP_5_2&view=patch), >>> >>> is this patch compatible with the pdoru Upload Progress Meter extension >>> or do I need to write something from scratch? > >> http://pecl.php.net/package/uploadprogress > > Ok so after examination of this extension it looks like it's basically > using the same code with the exception of no support for memcache from http://pdoru.from.ro/upload-progress-meter/upload-progress-meter-v4.1/upload_progress_meter/upload_progress_meter.c static int mmcache_loaded(void) { return 0; } static void * callback_mmcache( void *pointer, int read_bytes, int total_bytes, int what_happened ) { return NULL; } Doesn't look like much support for m(e)mcache :) > and > this is a requirement but my question was, is the provided patch > compatible with the pdoru extension (the pdoru extension works properl)? I don't know exactly, but I don't think, that it's 100% compatible, there was a reason for the PECL extension... chregu -- Liip AG // Schoeneggstrasse 5 // CH-8004 Zurich Tel +41 44 240 56 70 // Mobile +41 76 561 88 60 www.liip.ch // blog.liip.ch // GnuPG 0x5CE1DECB