Re: Re: cvs: php-src(PHP_5_2) / run-tests.php /ext/bz2/tests 005.phpt /ext/standard/tests/general_functions phpcredits.phpt phpinfo.phpt
/ext/standard/tests/strings sha1.phpt /ext/zlib/tests 005.phpt 006.phpt
| From: | Zoe Slattery | Date: | Fri, 28 Sep 2007 10:05:00 +0000 |
| Subject: | Re: Re: cvs: php-src(PHP_5_2) / run-tests.php /ext/bz2/tests 005.phpt /ext/standard/tests/general_functions phpcredits.phpt phpinfo.phpt /ext/standard/tests/strings sha1.phpt /ext/zlib/tests 005.phpt 006.phpt |
||
| References: | 1 2 | Groups: | php.cvs php.internals |
| Request: | Send a blank email to internals+get-32487@lists.php.net to get a copy of this message | ||
Michael Wallner wrote:
Nuno Lopes wrote:Zoe Slatterynlopess Fri Sep 14 15:28:04 2007 UTCLog: changes to run-tests.php: - change %s to %a - make %s = [^\r\n]+ - fix tests accordinglyI think this is a very bad change. While tests of bundled extensions can be updated accordingly, pecl extension tests have no way to be version agnostic in this regard. Mike - that's a fair point. When we looked through the PHP tests we found that the vast majority (all except 4) relied on the %s behaviour as is is currently implemented - that is *not* matching over a line end. Only 4 tests were actually intentionally using %s to match over line endings. From what you say it sounds as though many more of the PECL tests behave this way?