pdo_firebird: "RETURNING" queries/closeCursor (#43246/43271)
| From: | Hans-Peter Oeri | Date: | Mon, 12 Nov 2007 23:20:57 +0000 |
| Subject: | pdo_firebird: "RETURNING" queries/closeCursor (#43246/43271) | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-33102@lists.php.net to get a copy of this message | ||
Hi!
According to the archive, this might be the list for concrete diffs - if
not, please excuse me.
I tried pdo_firebird (CVS PHP_5_3) and quickly ran across to bugs:
a) RETURNING queries fail
pdo_firebird - against the published docs - wants to return stored
procedure return values by the "execute" call. As it is, RETURNING
queries (for the lower level library) go in the same bucket; big nono.
My proposed change removes "special" handling of stored procedure calls
alltogether - as it seems not only undocumented, but against the docs.
As a "side effect", RETURNING queries work again.
b) PDOStatement->closeCursor not implemented
Whenever I tried to re-use a prepared statement, I got an error msg
about reusing an open cursor. As it seems, mere cursor closing is not
currently implemented (discarding the statement closes the cursor).
My proposed change adds a minimal "cursor_closer".
Please excuse form and/or function of my diffs (or human language
mistake). I'm neither a C nor a PHP guru. Nevertheless I humbly present
those for your consideration.
HPO