Re: [PATCH] Clean up struct initalizations
| From: | Alexey Zakhlestin | Date: | Tue, 27 Nov 2007 14:34:46 +0000 |
| Subject: | Re: [PATCH] Clean up struct initalizations | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-33456@lists.php.net to get a copy of this message | ||
On 11/27/07, Ilia Alshanetsky <ilia@prohost.org> wrote:
> IMHO {0} is sufficiently clear for human consumption.
{NULL, 0, 0} brings real structure dimensions to the context, which is
good (less need to check "headers").
> On 27-Nov-07, at 8:49 AM, Andy Lester wrote:
>
> >
> > On Nov 27, 2007, at 2:53 AM, Stanislav Malyshev wrote:
> >
> >>> I've been working on making PHP build under more stringent error
> >>> checking, specifically -Wextra under GCC. This patch cleans up
> >>> dozens
> >>> of struct initializations that are valid C, but could hide future
> >>> problems.
> >>
> >> Doesn't C standard mandate filling up uninitialized fields with 0?
> >
> >
> > Yes. My patch is for human benefit, not the compiler's.
> >
> > --
> > Andy Lester => andy@petdance.com => www.petdance.com => AIM:petdance
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: http://www.php.net/unsub.php
> >
>
> Ilia Alshanetsky
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
--
Alexey Zakhlestin
http://blog.milkfarmsoft.com/