Re: question regarding type hinting parameters of php functions (array_slice)

From:	Stanislav Malyshev	Date:	Mon, 10 Dec 2007 19:03:18 +0000
Subject:	Re: question regarding type hinting parameters of php functions (array_slice)
References:	1 2 3 4 5 6 7 8 9 10 11	Groups:	php.internals
Request:	Send a blank email to internals+get-33905@lists.php.net to get a copy of this message

    if (ZEND_NUM_ARGS() >= 3 && Z_TYPE_P(length_param) != IS_NULL) {
+        convert_to_long(length_param);

Isn't convert_to_long non-separating one? I think the variable supposed to be separated before conversion, so convert_to_long_ex (and zval **) would be in place.

+    if (length == IS_NULL) {

Did you really mean IS_NULL here? -- Stanislav Malyshev, Zend Software Architect stas@zend.com http://www.zend.com/ (408)253-8829 MSN: stas@zend.com