Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_3) / zend_API.czend_API.h php-src/ext/standard type.c

On Feb 2, 2008 1:52 AM, Gregory Beaver <greg@chiaraquartet.net> wrote: > Rasmus Lerdorf wrote: > > Cristian Rodriguez wrote: > >> 2008/2/1, Marcus Boerger <helly@php.net>: > >>> - Fix callable/static mess, the following will now all result in a E_STRICT > >>> . binding a dynamic function as a static callback > >>> . static call of a dynamic function > >>> . is_callable() on a static binding to a dynamic function > >> > >> Does not compile.. > >> > >> php5.3/ext/spl/php_spl.c: In function 'zif_spl_autoload_register': > >> php5.3/ext/spl/php_spl.c:423: error: too few arguments to function > >> 'zend_is_callable_ex' > >> php5.3/ext/spl/php_spl.c: In function 'zif_spl_autoload_unregister': > >> php5.3/ext/spl/php_spl.c:515: error: too few arguments to function > >> 'zend_is_callable_ex' > >> make: *** [ext/spl/php_spl.lo] Error 1 > > > > Did you update your Zend/ directory? It compiles fine here. > > > > I've been working through this one with Marcus a bit, and even though he > > fundamentally disagrees with the concept, he still wrote the code. I > > can't say I would have done the same in his place. So thanks, Marcus. > > I and everyone in PEAR agrees, this was a very gallant move. For those > who are similarly grateful, Marcus does have a wishlist at > http://pecl.php.net/wishlist.php/helly :) To rectify a bit the shot, everyone agrees, but that's not the point :) The initial move was actually wrong, that does not mean that Marcus is the evil or does nothing good for PHP. That only means that it was a bad move and should be corrected. We all do such moves once or two. The problem is fixed now, thanks you. However that does not answer my questions, what's the gain to make such errors fatal? -- Pierre http://blog.thepimp.net | http://www.libgd.org