Re: Math functions (new parameter parsing)

Em Qua, 2008-02-13 às 01:31 +0100, Pierre Joye escreveu: > Hi! > > On Feb 13, 2008 1:04 AM, Felipe Pena <felipensp@gmail.com> wrote: > > Hi all, > > > > I made a patch for 5_3 where all functions in ext/standard/math.c use > > the new parameter parsing. (As was done in HEAD) > > I think it got lost between you and the list :) > > > If anyone think it good, let me know, and then i'll commit it. > > > > Several tests break with the patch. Hence, i'll fix them also, if > > agreed. :) > > How do they fail? I worry a bit about BC here. There are two cases. In most part of it: 003+ Warning: acos() expects exactly 1 parameter, 2 given ... 003- Warning: Wrong parameter count for acos() ... And breaking BC: 010+ 011+ Warning: acos() expects parameter 1 to be double, string given ... 012+ NULL 010- float(1.570796327) 014+ 015+ Notice: A non well formed numeric value encountered ... PS: The same behavior in HEAD. http://felipe.ath.cx/diff/math.diff > Thanks for your work! Thanks for your attention! :) -- Regards, Felipe Pena.