Re: bad test case that depends on user local ini

On 2007-12-31 14:53, Christian Hoffmann wrote:

There is another problem though: Tests which spawn their own php interpreter (such as Zend/tests/bug40236.phpt) do not load tmp-php.ini but use the global ini file which does contain extension* directives. These tests break. Ok, meanwhile I went through (hopefully) all test cases which spawn their own PHP interpreter and made them use -n (as most of those tests already do anyway).

Would committing this patch [1] be a valid compromise? I've yet another patch [2] which makes run-tests.php PHP calls (for determining PHP version etc.) use -n as well. The actual tests are still run with whatever arguments the user supplies to run-tests.php itself. If those patches could be applied, it would really be nice. Average users would still test with the global php ini to catch any regressions / ini-specific bugs, while distributions could easily force usage of no php.ini by simply passing -n as argument to run-tests.php. [1] http://home.hoffie.info/php_tests-ignore-php-ini.patch [2] http://home.hoffie.info/php_run-tests-ignore-php-ini.patch -- Christian Hoffmann

Attachment: [application/pgp-signature] OpenPGP digital signature signature.asc