Re: Re: Backporting to 5_3

On Thu, Mar 27, 2008 at 1:05 AM, Johannes Schlüter <johannes@php.net> wrote: > > On Thu, 2008-03-27 at 01:01 +0100, "Pierre Joye" wrote: > > On Thu, Mar 27, 2008 at 12:54 AM, Johannes Schlüter <johannes@php.net> wrote: > > > > > > > > And compile time JIT is fine as long as we don't have to care for > > > encoding, right? So this change won't be needed in 5.3. > > > > Except when one sends a xxMB post that you are not expecting and will > > not use. But that has been so for years, too bad though, 5.3 is the > > perfect time for such thing. > > which is handled by post_max_filesize and as long as we don't add error > handling it doesn't make a difference if that happens at compile- or > runtime. Indeed it makes a difference. In one case it is always initialized, in the other only if it is actually used (and not only if a _GET/_POST... exists in the script). That's a pretty big difference. -- Pierre http://blog.thepimp.net | http://www.libgd.org