Re: Win32 mail() issue and potential fix - needs better brains than me to verify solution.
| From: | Scott MacVicar | Date: | Tue, 22 Apr 2008 18:02:48 +0000 |
| Subject: | Re: Win32 mail() issue and potential fix - needs better brains than me to verify solution. | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-37181@lists.php.net to get a copy of this message | ||
Jani Taskinen wrote:
On Thu, 2008-04-17 at 17:59 +0100, Scott MacVicar wrote:What is the alternative to INI_STR if you just want the value? ScottHi Richard, The patch would fix it in this case but there is an underlying change that needs sorted. zend_ini_string()'s behaviour was changed to fix http://bugs.php.net/bug.php?id=42657 so that if the default value was NULL it would then return an empty string instead. http://cvs.php.net/viewvc.cgi/ZendEngine2/zend_ini.c?r1=1.39.2.2.2.18.2.6&r2=1.39.2.2.2.18.2.7 This broke the places that were relying on INI_STR returning the NULL?Propably, but INI_STR is evil and should never be used anyway.Should this fix be backed out and change ini_get and ini_set to deal with this for the userland?Hell no. Fix places using INI_STR incorrectly instead. (as in: make them NOT use INI_STR.. :) --Jani