Re: Building PHP. Clean builds. Noisy redefines.

Greetings, I'm also having some fun with php devel on windows and I just would like to report that along with _WIN32_WINNT there are few others macro redefinitions. Here is the warnings I saw on last compilation... I'm using the MSVC++ Express Edition, .Net 3 on XP Professional. c:\php-compile\php-5.2.6rc5\main\win95nt.h(75) : warning C4005: 'WINDOWS' : macro redefinition

       c:\php-compile\zlib-1.2.3-src\src\zlib\1.2.3\zlib-1.2.3\zconf.h(69) : see previous definition of 'WINDOWS'
c:\php-compile\php-5.2.6rc5\ext\gd\gd.c(4746) : warning C4005: 'max' : macro redefinition
       c:\arquivos de programas\microsoft visual studio 9.0\vc\include\stdlib.h(849) : see previous definition of 'max'
c:\php-compile\php-5.2.6rc5\ext\gd\gd.c(4747) : warning C4005: 'min' : macro redefinition
       c:\arquivos de programas\microsoft visual studio 9.0\vc\include\stdlib.h(850) : see previous definition of 'min'
c:\php-compile\php-5.2.6rc5\ext\gd\libgd\gd.c(29) : warning C4005: 'fabsf' : macro redefinition
       c:\arquivos de programas\microsoft visual studio 9.0\vc\include\math.h(288) : see previous definition of 'fabsf'
c:\php-compile\php-5.2.6rc5\ext\gd\libgd\gd.c(33) : warning C4005: 'floorf' : macro redefinition
       c:\arquivos de programas\microsoft visual studio 9.0\vc\include\math.h(301) : see previous definition of 'floorf'
c:\php-compile\php-5.2.6rc5\main\win95nt.h(75) : warning C4005: 'WINDOWS' : macro redefinition
       c:\php-compile\zlib-1.2.3-src\src\zlib\1.2.3\zlib-1.2.3\zconf.h(69) : see previous definition of 'WINDOWS'
c:\php-compile\php-5.2.6rc5\win32\glob.c(517) : warning C4090: 'function' : different 'const' qualifiers
c:\arquivos de programas\microsoft visual studio 9.0\vc\include\crtdbg.h(628) : warning C4005: '_malloca' : macro redefinition
       c:\arquivos de programas\microsoft visual studio 9.0\vc\include\malloc.h(220) : see previous definition of '_malloca'
c:\php-compile\php-5.2.6rc5\tsrm\readdir.h(10) : warning C4005: '_WIN32_WINNT' : macro redefinition
       c:\php-compile\php-5.2.6rc5\win32\time.c(27) : see previous definition of '_WIN32_WINNT'
c:\php-compile\php-5.2.6rc5\ext\curl\interface.c(1099) : warning C4098: 'zif_curl_init' : 'void' function returning a value
c:\php-compile\php-5.2.6rc5\ext\curl\interface.c(1099) : warning C4098: 'zif_curl_init' : 'void' function returning a value
c:\php-compile\php-5.2.6rc5\ext\curl\interface.c(1099) : warning C4098: 'zif_curl_init' : 'void' function returning a value
c:\php-compile\php-5.2.6rc5\ext\standard\scanf.c(397) : warning C4129: '%' : unrecognized character escape sequence
c:\php-compile\php-5.2.6rc5\ext\standard\scanf.c(397) : warning C4129: '%' : unrecognized character escape sequence

Thanks, Jaris. Richard Quadling wrote:

On 22/04/2008, Antony Dovgal <tony@daylessday.org> wrote:

On 22.04.2008 15:01, Richard Quadling wrote:

    
Another warning is that some of the constants are redefined to a

different value from the ones that are part of the compiler. The /TRSM/readdir.h, _WIN32_WINNT is redefined from 0x0600 in C:\Program Files\Microsoft

SDKs\Windows\v6.1\include\sdkddkver.h(186).

This 1 #define causes a LOT of noise during compilation. I know I could suppress all the warnings, but with so much noise, how does anyone see the true warnings in the noise? By adding a #undef _WIN32_WINNT before #define _WIN32_WINNT 0x0400, this removes the warning. It is more or less every .c compile.

http://dev.daylessday.org/diff/readdir_winnt.diff Did I get you right ? -- Wbr, Antony Dovgal

Yes on the patch. There are a few more like this. It is just a cosmetic issue. I am using Microsoft Visual C++ 2008 Express Edition with the Windows Server 2008 and .NET 3.4 SDK. I'm NOT running Apache (so runtime version issues there don't apply), and I am only playing/learning - this is going nowhere near my live/dev servers. Just learning. My next goal is to get a version of Linux so I can build and test my suggestions on 2 platforms. Hopefully, my patches/suggestions will have more support! Thank you. Richard. -- *Jarismar Chaves da Silva, M.Sc.* *ADP**Labs** Brazil** *jarismar_silva@adplabs.com.br <mailto:jarismar_silva@adplabs.com.br> http://www.adp.com