Re: cvs: php-src(PHP_5_3) /ext/session mod_user.c mod_user.h php_session.h session.c

On Apr 24, 2008, at 3:19 AM, Antony Dovgal wrote:

On 08.03.2008 02:20, Gwynne Raskind wrote:

gwynne Fri Mar 7 23:20:32 2008 UTC

 Modified files:              (Branch: PHP_5_3)
   /php-src/ext/session	mod_user.c mod_user.h php_session.h session.c   Log:
 MFH: fix bug #32330 (session_destroy, "Failed to initialize storage module", custom session handler)

Gwynne, what about 5_2? It still leaks memory: # cat /local/qa/5_2/ext/session/tests/session_set_save_handler_error4.diff 012+ [Thu Apr 24 02:05:35 2008] Script: '/local/qa/5_2/ext/session/tests/session_set_save_handler_error4.php' 013+ /local/qa/5_2/Zend/zend_vm_execute.h(1805) : Freeing 0x0108F0F0 (24 bytes), script=/local/qa/5_2/ext/session/tests/session_set_save_handler_error4.php 014+ Last leak repeated 5 times 015+ [Thu Apr 24 02:05:35 2008] Script: '/local/qa/5_2/ext/session/tests/session_set_save_handler_error4.php' 016+ /local/qa/5_2/Zend/zend_variables.h(45) : Freeing 0x01091DA8 (9 bytes), script=/local/qa/5_2/ext/session/tests/session_set_save_handler_error4.php 017+ /local/qa/5_2/Zend/zend_variables.c(120) : Actual location (location was relayed) 018+ Last leak repeated 5 times 019+ [Thu Apr 24 02:05:35 2008] Script: '/local/qa/5_2/ext/session/tests/session_set_save_handler_error4.php' 020+ /local/qa/5_2/ext/session/session.c(1512) : Freeing 0x01093A48 (48 bytes), script=/local/qa/5_2/ext/session/tests/session_set_save_handler_error4.php 021+ === Total 13 memory leaks detected ===

I was told not to commit this fix to 5.2 as it represented a significant change to the session module. I can't say why 5.2 is leaking memory since I never touched it. -- Gwynne, Daughter of the Code "This whole world is an asylum for the incurable."