Re: Couple Windows build fixes

Then we'd better ask for him. Matt's been pushing patches all across the PHP source (if mostly at the Zend Engine) for ages. He comes and goes, but pretty much all of his patches were subsequently accepted. I don't recall off-hand which bits of the source he was given karma for a few weeks ago, but it's downright weird that it was ever limited.

He never asked. Steph Fox wrote:

Hi Hannes, CVS HEAD wasn't updated yet with the Windows build system because I was waiting for re2c development to settle down first, given that there was no re2c binary available that PHP could be built with at all for several weeks. But I agree with you, Matt should've been given access to everything from Day One, we all know he's brilliant :) - Steph ----- Original Message ----- From: "Hannes Magnusson" <hannes.magnusson@gmail.com> To: "Matt Wilmas" <php_lists@realplain.com> Cc: <internals@lists.php.net> Sent: Wednesday, May 07, 2008 9:16 PM Subject: Re: [PHP-DEV] Couple Windows build fixes

Could someone explain to me why he doesn't have karma? -Hannes On Wed, May 7, 2008 at 5:28 PM, Matt Wilmas <php_lists@realplain.com> wrote:

Hi, One patch for 5.3 and one for HEAD, where they're not synched with the other. 5.3's math changes the other day missed one change to the php_* function (snaps are failing). And HEAD's Win Makefile still contains references to flex.skl after the re2c change, which causes an error for me, though its snaps are building, so maybe I'm the only one? - Matt -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php