Re: [HEADS UP] pecl/phar is now ext/phar

On 13.05.2008 01:45, Gregory Beaver wrote:

Thanks to all who have contributed, particularly Marcus, Steph, Lars, and the others who chimed in with ideas on the list.

phar_detect_phar_fname_ext() fails if is_complete = 1 and filename contains ".". For example: Breakpoint 1, phar_detect_phar_fname_ext (filename=0x124db80 "/local/qa/5_3.zts/ext/phar/tests/DataArchive.phar", check_length=1, ext_str=0x7fff44a08fd8, ext_len=0x7fff44a08fcc, executable=1, for_create=0, is_complete=1, tsrm_ls=0xf5b0c0) at /local/qa/5_3.zts/ext/phar/phar.c:1557

1557            int filename_len = strlen(filename);

(gdb) <..skip..>

1651            switch (phar_check_str(filename, *ext_str, *ext_len, executable, for_create TSRMLS_CC)) {

(gdb)

1656                            if (is_complete) {

(gdb)

1657                                    return FAILURE;

(gdb) p *ext_str $9 = 0x124db8d ".zts/ext/phar/tests/DataArchive.phar" This causes numerous test failures:

Tests failed    :  214 ( 56.8%) ( 58.8%)
Tests passed    :  150 ( 39.8%) ( 41.2%)

-- Wbr, Antony Dovgal