Re: I suppose I should be happy ...

From: Date: Fri, 30 May 2008 10:04:59 +0000
Subject: Re: I suppose I should be happy ...
References: 1  Groups: php.internals 
Request: Send a blank email to internals+get-38010@lists.php.net to get a copy of this message
Hi Richard, I never even looked for bug reports, I found this while trying to deal with an issue one of our customers reported. I then tracked through the code and read cmd.exe /? After I read what it said it did for quotes, I created a fix and tested it. I guess none of the Windows developers saw the bug report. Scott Richard Quadling wrote:
Hi. From the recent daily cvs changelog ... +2008-05-29 Scott MacVicar <scott@macvicar.net> +
+    * (PHP_5_2)
+      NEWS
+      TSRM/tsrm_win32.c:
+      MFH: Fix a bug when command is quoted and parameters are quoted
during call
+      to exec, the result is that cmd.exe /c strips the first and last quote.
+
+    * (PHP_5_3)
+      TSRM/tsrm_win32.c:
+      MFH: Fix bug when command is quoted and parameters are quoted during call
+      to exec, the result is that cmd.exe /c strips the first and last quote.
+
+    * TSRM/tsrm_win32.c:
+      Fix bug when command is quoted and parameters are quoted during call to
+      exec, the result is that cmd.exe /c strips the first and last quote.
+ This really should have been tagged with all those bogus-fied bugs. A patch was supplied in August 2007 and there were many discussions in the bugs by many users. http://bugs.php.net/bug.php?id=34671 http://bugs.php.net/bug.php?id=35961 http://bugs.php.net/bug.php?id=25361 (There may be others.) Until now. What changed? Can someone please check out #15818, #43784 with the patch at #43261 Thanks.


« previous php.internals (#38010) next »