Re: Re: Focus on HEAD

Hi all Em Seg, 2008-06-09 às 18:55 +0100, Steph Fox escreveu: > Hi all, > > Andrei doesn't have time to review this lot (covers ext/standard). Could > someone please check it for clangers? > > Thanks, > > - Steph Here's the rest (ext/* and main/*): http://felipe.ath.cx/diff/unicode-check.diff - Removed: - if (UG(unicode)) - unicode_semantics() function - pcre_cache_entry.unicode_mode - Changed: - ZEND_STR_TYPE -> IS_UNICODE - convert_to_text -> convert_to_unicode - convert_to_text_ex -> convert_to_unicode_ex MySQL part: http://felipe.ath.cx/diff/mysql-unicode-check.diff http://felipe.ath.cx/diff/mysql-tests-unicode-checks.diff (removed the ini_set("unicode.semantics") checks) MySQL guys, the non-unicode tests can be removed? (those that uses SKIPIF...) > > > > > Sure. > > > > Steph Fox wrote: > >> > >>> Is there a patch that does that? I'm fine with removing these checks. > >> > >> If there isn't already, there soon will be :) > >> > >> Did you want to review it prior to commit? > >> > >> - Steph > >> > >> > > > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php -- Regards, Felipe Pena.