Re: [PATCH] unix path separators in spl

From:	Steph Fox	Date:	Thu, 19 Jun 2008 19:13:47 +0000
Subject:	Re: [PATCH] unix path separators in spl
References:	1 2 3 4 5 6	Groups:	php.internals
Request:	Send a blank email to internals+get-38432@lists.php.net to get a copy of this message

Hi Stas,

Doesn't PATH_SEPARATOR use DEFAULT_SLASH?
Should be DIRECTORY_SEPARATOR

Bleh, must be nearly switching-off time

and it's "\" on windows (PATH_SEPARATOR is ";" ). Do you propose to change it to "/"?

dirsep_str[0] = DEFAULT_SLASH; dirsep_str[1] = '\0'; REGISTER_STRING_CONSTANT("DIRECTORY_SEPARATOR", dirsep_str, CONST_CS|CONST_PERSISTENT);

Path comparison is important.
I thought so too until I couldn't find any broken tests.
With all due respect to phpt, these are very primitive code samples testing very narrow functional areas. They do not come anywhere near the stuff people do in real-life apps, combining different functions and extensions.

Fair point. I like Marcus' idea tho'. - Steph

-- Stanislav Malyshev, Zend Software Architect stas@zend.com http://www.zend.com/ (408)253-8829 MSN: stas@zend.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php