Re: OpenSSL and Phar

On Sun, Jun 22, 2008 at 10:32 PM, Steph Fox <steph@phparch.com> wrote: > It seems we don't use the openssl extension API at all in ext/phar, just the > actual OpenSSL headers and libs. That means Phar with OpenSSL support can be > both built and run without ext/openssl being built at all, but requires > third-party libs (under Windows at least - ssleay32.dll and libeay32.dll) in > the same way that ext/openssl does. > > I'm wondering if we shouldn't have a separate configuration option for this > - something like --enable-phar-ssl - rather than testing for --with-openssl > in the config line. > > The chief advantage of this approach is that it doesn't matter whether > phar-ssl is built as shared or not, since the dependency is outside PHP. > > Thoughts? --with-openssl is used by ext/openssl and will continue to be used like it is now (I'm thinking of adding --with-openssl-dir for consistency but that's all). I'm not sure it makes sense to have the ssl optional features enabled but not ext/openssl. Or to say it better, I don't see the gain. What is the gain besides being able to say: "heh you can use the ssl features without having ext/openssl but you need the libs anyway"? About the SSL ibraries on windows, they are always distributed as dll in the PHP releases. Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org