Re: cvs: php-src(PHP_5_3) /ext/mcrypt mcrypt.c php_mcrypt.h /ext/mcrypt/tests bug35496.phpt bug41252.phpt bug43143.phpt mcrypt_cbc.phpt
mcrypt_cbf.phpt mcrypt_decrypt.phpt
| From: | Derick Rethans | Date: | Thu, 03 Jul 2008 14:23:43 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_3) /ext/mcrypt mcrypt.c php_mcrypt.h /ext/mcrypt/tests bug35496.phpt bug41252.phpt bug43143.phpt mcrypt_cbc.phpt mcrypt_cbf.phpt mcrypt_decrypt.phpt |
||
| References: | 1 | Groups: | php.cvs php.internals |
| Request: | Send a blank email to internals+get-38733@lists.php.net to get a copy of this message | ||
On Thu, 3 Jul 2008, Pierre-Alain Joye wrote:
> pajoye Thu Jul 3 13:50:15 2008 UTC
>
> Modified files: (Branch: PHP_5_3)
> /php-src/ext/mcrypt mcrypt.c php_mcrypt.h
> /php-src/ext/mcrypt/tests bug35496.phpt bug41252.phpt bug43143.phpt
> mcrypt_cbc.phpt mcrypt_cbf.phpt
> mcrypt_decrypt.phpt
> Log:
> - fix mcrypt_iv on windows, use urandom equivalent
> - MFH, code cleaning and reorganisation
WTF, you mentioned that you'd be doing this, and I agreed to a patch
that you showed for it. You *NEVER* mentioned anything of touching every
single line of this code. There is 1. no good reason, 2.
you should discuss that with the maintainer and 3. NEVER mix code and
whitespace changes. Revert this patch, now.
regards,
Derick
--
Derick Rethans
http://derickrethans.nl | http://ezcomponents.org | http://xdebug.org