Re: zend_inline_hash_function reimplementation
| From: | Scott MacVicar | Date: | Mon, 21 Jul 2008 21:24:12 +0000 |
| Subject: | Re: zend_inline_hash_function reimplementation | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-39153@lists.php.net to get a copy of this message | ||
There is an aligned version of the algorithm available but its slower, there is also a 64-bit version in the works. I emailed the author about its progress to check.
At the moment adding both looks the way forward, i'll benchmark a PPC version of the algorithm shortly.
Scott
On 21 Jul 2008, at 21:58, Stanislav Malyshev wrote:
Hi! I understand this patch has potential portability issues for architectures that won't be able to read int's unaligned. Maybe we could keep both of them and do some configure test to see if it works fine, if not - use the old one? Also I understand that this function returns uint while old hash returned ulong. What happens with that on 64-bit platforms? --Stanislav Malyshev, Zend Software Architect stas@zend.com http://www.zend.com/ (408)253-8829 MSN: stas@zend.com