Re: Patch for HTTP successful status codes
| From: | Noah Fontes | Date: | Wed, 23 Jul 2008 17:40:55 +0000 |
| Subject: | Re: Patch for HTTP successful status codes | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-39240@lists.php.net to get a copy of this message | ||
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
David Zülke wrote:
> Yeah. We discussed that quite a while back when I sent over the
> "ignore_errors" options patch-like thing in November:
> http://thread.gmane.org/gmane.comp.php.devel/46003
>
> I think we should do it.
>
> But what about other 3xx redirect codes? How are those handled?
I think PHP implicitly follows any Location headers it can. That's
probably not the right behavior, but for an automated process it's not bad.
I think that 3xx status codes, if they appear without a Location header,
should also probably not throw errors. They could provide valuable
information about the status of a page (particularly 304 Not Modified),
so I've updated the patch:
http://cynigram.com/~nfontes/http_fopen_wrapper.patch
BTW, any chance this could be rolled into 5.3? I think the BC break is
pretty non-notable, and it would be nice to stop throwing errors for
successful responses.
Regards,
Noah
- --
Noah Fontes
Bitextender
http://www.bitextender.com/
Phone: +1 919 349 9826
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFIh20nhitK+HuUQJQRAqipAJ9pndnS4K4L5GtPzoYsEguYQSgSXwCfb6yC
YnohwjT8KYCiADQehg4Jm2A=
=UzO8
-----END PGP SIGNATURE-----