Re: 5.3 feature freeze rapidly approaching
| From: | Marcus Boerger | Date: | Thu, 24 Jul 2008 18:43:25 +0000 |
| Subject: | Re: 5.3 feature freeze rapidly approaching | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-39279@lists.php.net to get a copy of this message | ||
Hello Felipe,
awesome!!!! Just commit.
marcus
Thursday, July 24, 2008, 5:08:03 PM, you wrote:
> Em Qua, 2008-07-23 às 18:52 +0200, Marcus Boerger escreveu:
>> And then there are these:
>>
>> - should we finally change:
>> typedef int (*apply_func_args_t)(void *pDest, int num_args, va_list args, zend_hash_key
>> *hash_key);
>> to
>> typedef int (*apply_func_args_t)(void *pDest TSRMLS_DC, int num_args, va_list args,
>> zend_hash_key *hash_key);
>> so that we can drop a bunch of TSRMLS_FETCH()'es.
> Would it be like that?
> http://felipe.ath.cx/diff/zend_hash_apply_with_arguments.diff
> --
> Regards,
> Felipe Pena.
Best regards,
Marcus