Re: towards 5.3 alpha1

Hello, On 2008-07-26, at 14:21, Arnaud Le Blanc wrote:

On Saturday 26 July 2008 13:57:45 Lukas Kahwe Smith wrote:

On 26.07.2008, at 13:02, Johannes Schlüter wrote:

Again a general request to the developer and user community at large: Please concentrate on finding&fixing bugs instead of functional changes (including arginfo and parameter_parsing) and to make sure we have all changes covered in the wiki [2] so they can be added to release notes and the documentation.

Speaking of which, just going through the open 5.3 bugs that have not been assigned to a developer I see the following ones as looking to be important to be dealt with: http://bugs.php.net/bug.php?id=45044 (relative paths not resolved correctly) http://bugs.php.net/bug.php?id=43695 (Asynchronous socket connection timing issue) http://bugs.php.net/bug.php?id=45384 (parse_ini_file will result in parse error with no trailing newline) http://bugs.php.net/bug.php?id=45392 (ob_start()/ob_end_clean() and memory_limit)

I have just taken a look at this bug, and the problems seems to be in php_request_shutdown function from main/main.c. It just executes buffers flush no matter what outcome of the script was (I mean error/success) (somewhere around line 1495): zend_try { php_end_ob_buffers((zend_bool)(SG(request_info).headers_only?0:1) TSRMLS_CC); } zend_end_try(); It can be avoided by adding if-stmt checking if there was an error: if (!PG(last_error_message) || !(PG(last_error_type) & E_ERROR)) { zend_try { php_end_ob_buffers((zend_bool)(SG(request_info).headers_only?0:1) TSRMLS_CC); } zend_end_try(); } I am not sure if it is the right solution, or if it does not introduce any other problems I am not aware of (I have done "make test" and haven;t noticed anything strange.) Cheers Michal

http://bugs.php.net/bug.php?id=44842 (parse_ini_file keys that start/ end with underscore) http://bugs.php.net/bug.php?id=45288 (set_include_path() functionality broken) http://bugs.php.net/bug.php?id=45608 (closures don't work in static methods) The rest are either assigned or PDO bugs (again, we really really really need someone that looks after PDO). Of course there are also still tons of open 5.2 bugs [1] :( regards, Lukas Kahwe Smith smith@pooteeweet.org [1]

http://bugs.php.net/search.php?cmd=display&status=Open&search_for=&php_os=&boolean=1&author_email=&bug_age=0&by=&order_by=id&direction=ASC&phpver=5.2&limit=30&assign=&begin=0

--PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Hi, For "closures don't work in static methods" (45608), this is because a closure declared in a static method will always be called statically. The example given in the report works if the closure is explicitly declared as static, but as shown by the bug report it may be better to implicitly inherit the ACC_STATIC flag of the declaring method. It seems that Christian planed to add this to his patch but it has never be included. This could be as simple as this: http://arnaud.lb.s3.amazonaws.com/closure_static.patch For "relative paths not resolved correctly" (45044) I added a comment on the report about the cause of the bug, but I don't know what is the better way to fix that. Regards, Arnaud -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php