Re: [PATCH] New functions: array_replace[_recursive]

From: Date: Thu, 31 Jul 2008 18:06:08 +0000
Subject: Re: [PATCH] New functions: array_replace[_recursive]
References: 1 2 3  Groups: php.internals 
Request: Send a blank email to internals+get-39516@lists.php.net to get a copy of this message
Hi, On Thu, 2008-07-31 at 11:48 -0500, Matt Wilmas wrote: > Ugh, I hate that reference/recursion stuff! I have a hard time following > what's happening, and am not sure how some of those checks, etc. even work > in php_array_merge() (which I was working from). :-/ I tried changing a few > parts, and unfortunately couldn't fix it. I will look at it further when I > have some more time, and will of course let you know if it's fixed. Sorry. > :-( I think I found a think: you're iterating over src and src_entry, but doing the recursion check using Z_ARRVAL_PP(dest_entry)->nApplyCount, I didn't test it (need food first) but should do that with src_entry. That's at least where I'd poke around, can you try that, else I'll dig around there, after having some food :-) johannes

« previous php.internals (#39516) next »