Removing redundant shebang line check

From: Date: Fri, 01 Aug 2008 11:40:56 +0000
Subject: Removing redundant shebang line check
Groups: php.internals 
Request: Send a blank email to internals+get-39536@lists.php.net to get a copy of this message
Hi, The proposed patch removes code that implemented shebang line support (#! /usr/bin/php). Starting with PHP-5.3 it is handled by scanner, and we don't need to check it twice. With this check removed, it's become possible to eliminate the open() syscall (and also several fstat() and mmap() calls) for the requested file with opcode caches. The patch does it by replacing VCWD_FOPEN() in php_fopen_primary_script() by zend_open_stream() which call for callback that can be overridden by opcode cache. I like to commit it into HEAD and PHP_5_3 on weekend. I hope nobody have objections. Thanks. Dmitry.

« previous php.internals (#39536) next »