Re: clearstatcache change

On Wed, 2008-08-06 at 21:00 +0200, Arnaud Le Blanc wrote: > > > btw. I just noticed chroot() calls this > > > realpath_cache_clean()..intentional? I'd assume that, as /foo inside a chroot is different from /foo outside... > Also some streams stuff uses the > > > php_clear_stat_cache() func but those should propably use the > > > realpatch_cache_del() instead and not blow away whole cache? > > > > Yes, I think too. > > I added that to your patch: > > > > http://arnaud.lb.s3.amazonaws.com/clearstatcache_optional_params.patch > > :) > > > > It also adds the "filename" argument to > > clearstatcache([bool clear_realpath_cache[, filename]]) > > I reply to myself, actually this may cause troubles to not clear the full > cache in plain_wrapper.c :/ I updated the patch, just left the filename > argument to clearstatcache(). If you fix the arginfo like Hannes it's, good. If the name of the second parameter in the proto ("filename") is the same as in the implementation ("pathname") it might even be a bit better :-) johanes