Re: Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend.h zend_API.c zend_execute_API.c zend_vm_def.h zend_vm_execute.h php-src/main main.c php.h

Hello Etienne, Friday, August 8, 2008, 9:54:49 PM, you wrote: > Hello, > On Fri, Aug 8, 2008 at 9:50 PM, Etienne Kneuss <colder@php.net> wrote: >> Hello, >> >> On Fri, Aug 8, 2008 at 7:10 PM, Marcus Boerger <helly@php.net> wrote: >>> helly Fri Aug 8 17:10:49 2008 UTC >>> >>> Modified files: >>> /php-src/main main.c php.h >>> /ZendEngine2 zend.h zend_API.c zend_execute_API.c zend_vm_def.h >>> zend_vm_execute.h >>> Log: >>> - Turns out the easy solution for correct error_handling doesn't work. So >>> we need to provide save/replace/restore functions right away. It also >>> to save/restore in the vm. >>> >>> >>> -- >>> Zend Engine CVS Mailing List (http://cvs.php.net/) >>> To unsubscribe, visit: http://www.php.net/unsub.php >>> >> >> here are the patches to adapt the source with your changes: >> >> >> http://patches.colder.ch/php-src/error_handling_HEAD.patch?markup >> >> http://patches.colder.ch/php-src/error_handling_53.patch?markup >> > Forgot to mention it: there is something weird in mysqli_driver.c, I > don't know what the author's original intention was, but it looks > wrong. > c.f. FIXME >> Let me see if you find something weird. Looks perfectly correct to me. And yeah the mysql stuff seems to be misusing the the function. Best regards, Marcus