run-tests.php esacapeshellarg, portability
| From: | Pierre Joye | Date: | Sun, 10 Aug 2008 15:31:41 +0000 |
| Subject: | run-tests.php esacapeshellarg, portability | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-39809@lists.php.net to get a copy of this message | ||
hi!
While fixing broken tests (linux or win), I found that shell arguments
are manually escaped. Using escapeshellargs is more portable and avoid
duplicate tests only to fix shell argument issues (& usage for
example).
Here is a patch to add escapeshellarg usage:
http://pierre.libgd.org/patches/runtests_5_3_escapeshellarg.patch.txt
A couple of tests need changes, like:
inisetting="foo"
will become
inisetting=foo
or
inisetting=""
to
inisetting=
Please test the patch or let me know if you have any objection :)
Cheers,
--
Pierre
http://blog.thepimp.net | http://www.libgd.org