Re: handlerify get_closure
| From: | Dmitry Stogov | Date: | Wed, 13 Aug 2008 07:44:59 +0000 |
| Subject: | Re: handlerify get_closure | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-39903@lists.php.net to get a copy of this message | ||
Hi Etienne,
I don't see serious issues in implementation except for I would prefer to add checks if get_closure handler is NULL.
However in general I don't see any use case for this new handler.
From my point of view, it is always possible to use the Closures class itself and I cannot imagine case when someone need this handler.
Anyway, I won't object against patch if most of @internals like it.
Thanks. Dmitry.
Etienne Kneuss wrote:
Hi, http://patches.colder.ch/Zend/zend_get_closure_handler_53.patch?markup http://patches.colder.ch/Zend/zend_get_closure_handler_HEAD.patch?markup regards