Re: Re: Question on php_image_type_to_mime_type

Hello Mehdi, Friday, August 15, 2003, 11:20:52 PM, you wrote: MA> Marcus Börger wrote: >> Hello Mehdi, >> >> Friday, August 15, 2003, 10:47:41 PM, you wrote: >> >> MA> Marcus Börger wrote: >> >> >>>>Hello Mehdi, >>>> >>>>Friday, August 15, 2003, 10:22:28 PM, you wrote: >>>> >>>>MA> >>I'm in php-src/ext/standard/image.c (revision 1.92) >>>> >>>> >>>>>>>Looking at php_image_type_to_mime it seems like there are two constants >>>>>>>not handled : >>>>>>> IMAGETYPE_JB2 >>>>>>> IMAGETYPE_JPX >>>>>>> >>>>>>>Am I looking at the good version of the C file ? >>>>>> >>>>>> >>>>>>Yes. >>>> >>>> >>>>MA> Shouldn't be corrected ? >>>> >>>>No, they are used elsewhere, too. If you mean the support is missing, feel >>>>free to add it. >>>> >> >> >> MA> Hi Marcus, >> >> MA> I don't have karma to php-src :) >> MA> Here's what should be changed : >> >> MA> constant mime-type >> >> MA> IMAGETYPE_JPX image/jpx >> MA> IMAGETYPE_JB2 image/jb2 >> >> Which source are those based on? >> >> MA> JB2 : MA> http://cgi.netscape.com/cgi-bin/pi_moreinfo.cgi?PID=11473 MA> JPX : zíuC MA> ÖFú=†yV‚±$http://www.ietf.org/internet-drafts/draft-singer-jp2-01.txt Both are not official and the ietf draft was declined (it's outdated and didn't make it as a rfc). So i don't really see why i should change the current behavior and implement something non standard. -- Best regards, Marcus mailto:helly@php.net